Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move asset registry compiler to a tools/compiler subdirectory #2

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

hdevalence
Copy link
Contributor

No description provided.

Comment on lines -10 to -22
build:
name: Build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
override: true
- name: Build Project
run: cargo build --release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the separate build step since it's implied by test

@hdevalence hdevalence merged commit 0b81755 into main Apr 11, 2024
3 checks passed
@grod220 grod220 deleted the restructure branch April 11, 2024 09:19
@grod220
Copy link
Contributor

grod220 commented Apr 11, 2024

We have to change this too: https://github.com/prax-wallet/registry/blob/main/README.md?plain=1#L36-L38

We can't run cargo run from registry/tools/compiler either right now as it outputs a registry folder locally there and not in the parent.

We can either:

  • Change docs to run cargo run --manifest-path tools/compiler/Cargo.toml from root
  • Or change the code to output to the root's registry folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants